Skip to content

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added IO CSV read_csv, to_csv Arrow pyarrow functionality labels Dec 6, 2023
@@ -66,7 +66,6 @@ def test_quote_char_basic(all_parsers):
tm.assert_frame_equal(result, expected)


@xfail_pyarrow # ValueError: The 'quoting' option is not supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m pretty sure there are a bunch of these. I’ll try to find my old branch when back at my desk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like i was thinking of "quoting", not "quotechar", never mind.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke added this to the 2.2 milestone Dec 6, 2023
@mroeschke mroeschke merged commit fce7760 into pandas-dev:main Dec 6, 2023
@mroeschke mroeschke deleted the bug/arrow/quotechar_csv branch December 6, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: read_csv with engine='pyarrow' ignores quotechar option
3 participants